radiorabe / dabplus-on-air-processing

Liquidsoap based DAB+ on air processing solution
https://build.opensuse.org/project/show/home:radiorabe:dab
4 stars 2 forks source link

Switch from dabplus-odr-padenc@.service to odr-padenc@.service #2

Closed paraenggu closed 7 years ago

paraenggu commented 7 years ago

As discussed and decided during November, the odr-padenc package now uses its own systemd service unit template (which can also be used without the dabplus-on-air-processing. Switch to this one and adapt the path accordingly.

hairmare commented 7 years ago

The original odr-padenc service file also had Before=liquidsoap@dabplus-on-air-processing.service. I'm not sure how I could solve this with just dabplus-on-air-processing.service (which I don't plan on using since it's more pain than help anyway).

Any ideas? I'm not sure what to do because liquidsoap@.service is in a different package as well.

paraenggu commented 7 years ago

Maybe we should get rid of dabplus-on-air-processing.service completely (as it only acts as a meta-service anyway) and document (or install) an unit override for code>odr-padenc@dabplus-on-air-processing.service</code which specifies the appropriate start-up order (code>Before=[liquidsoap@dabplus-on-air-processing.service](https://github.com/radiorabe/centos-rpm-liquidsoap/blob/master/liquidsoap%40.service)</code and maybe also a code>[RequiredBy=](https://www.freedesktop.org/software/systemd/man/systemd.unit.html#WantedBy=)[liquidsoap@dabplus-on-air-processing.service](https://github.com/radiorabe/centos-rpm-liquidsoap/blob/master/liquidsoap%40.service)</code directive). Or the other way round for the code>[liquidsoap@dabplus-on-air-processing.service](https://github.com/radiorabe/centos-rpm-liquidsoap/blob/master/liquidsoap%40.service)</code (with code>After=[odr-padenc@dabplus-on-air-processing.service](https://github.com/radiorabe/centos-rpm-odr-padenc/blob/master/odr-padenc%40.service)</code and code>Requires=[odr-padenc@dabplus-on-air-processing.service](https://github.com/radiorabe/centos-rpm-odr-padenc/blob/master/odr-padenc%40.service)</code).