radiorabe / nowplaying

Songticker 🦉
https://songticker.rabe.ch/
GNU Affero General Public License v3.0
2 stars 1 forks source link

Merge with newer code from nowplaypadgen project #8

Open paraenggu opened 5 years ago

paraenggu commented 5 years ago

radiorabe/nowplaypadgen provides modern replacements for the Show, Track and TimePeriod objects (including tests and docs). Those could be integrated and replace the current objects.

hairmare commented 5 years ago

From what I've seen some of the linked modules seem to cover a more narrow use case than what we are currently doing in nowplaying.

IMO there is still some refactoring to be done to make this replacement possible. Mainly the input parts are what still needs some work as those don't have much test coverage yet. I'm also not quite sure on how we would proceed on the nowplaypadgen side of things. Do we want it to stay viable as a standalone module in it's own right. I certainly think it might be of interest to a larger audience if it stays standalone.

We also need to consider how we would like to handle our core python object models going forward. I've been considering a solution based on something like a rabe.commons python module that is primarily there to contain some very simple and abstract base modules but that is most certainly overkill.