search

radish-bdd / radish

Behavior Driven Development tooling for Python. The root from red to green.
https://radish-bdd.github.io
MIT License
181 stars 49 forks source link

Bugfix for windows test remove CR #381

Closed fliiiix closed 5 years ago

fliiiix commented 5 years ago

On windows the stdout contains an additional \r or CR which means the strings don't match Bla\r\n <> Bla\n. So this Commit removes all CR characters from stdout.

fliiiix commented 5 years ago

I think this is the cleanest way to ensure line endings are the same on windows and linux.

codecov[bot] commented 5 years ago

Codecov Report

Merging #381 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #381   +/-   ##
======================================
  Coverage    78.6%   78.6%           
======================================
  Files          38      38           
  Lines        1519    1519           
  Branches      262     262           
======================================
  Hits         1194    1194           
  Misses        300     300           
  Partials       25      25
Flag Coverage Δ
#unittests 78.6% <ø> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update bc60b3c...07a9c5e. Read the comment docs.