search

radish-bdd / radish

Behavior Driven Development tooling for Python. The root from red to green.
https://radish-bdd.github.io
MIT License
181 stars 49 forks source link

fix argument parsing for --scenarios #412

Closed fliiiix closed 2 years ago

codecov[bot] commented 3 years ago

Codecov Report

Merging #412 (34bf8ad) into master (1685a48) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #412   +/-   ##
=======================================
  Coverage   35.60%   35.60%           
=======================================
  Files          45       45           
  Lines        2101     2101           
  Branches      356      356           
=======================================
  Hits          748      748           
  Misses       1330     1330           
  Partials       23       23
Flag Coverage Δ
unittests 35.60% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/radish/__main__.py 34.95% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1685a48...34bf8ad. Read the comment docs.

timofurrer commented 3 years ago

Tests would be awesome :)

fliiiix commented 3 years ago

to quote rkh: "don't include tests. tests just bloat the code base. just commit, the users will complain if you break anything."

fliiiix commented 3 years ago

Ok added some tests BUT two things if not all scenarios are run this is considered a failure? Is this by design? (This is not what I would expect)

And the second thing is to use the -s=1 syntax was only in the help for the stable radish so question is if we want to support that on master since click does not show it like this in the help -s, --scenarios TEXT

fliiiix commented 2 years ago

no intention to do that anytime soon