search

radish-bdd / radish

Behavior Driven Development tooling for Python. The root from red to green.
https://radish-bdd.github.io
MIT License
181 stars 49 forks source link

WIP: Feature/support multiple tags on single line #421

Closed fliiiix closed 1 year ago

fliiiix commented 3 years ago
codecov[bot] commented 3 years ago

Codecov Report

Base: 86.03% // Head: 86.33% // Increases project coverage by +0.30% :tada:

Coverage data is based on head (ff246b8) compared to base (cb8b86d). Patch has no changes to coverable lines.

:exclamation: Current head ff246b8 differs from pull request most recent head e1ae80a. Consider uploading reports for the commit e1ae80a to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #421 +/- ## ========================================== + Coverage 86.03% 86.33% +0.30% ========================================== Files 39 39 Lines 2342 2401 +59 ========================================== + Hits 2015 2073 +58 - Misses 327 328 +1 ``` | Flag | Coverage Δ | | |---|---|---| | unittests | `86.33% <0.00%> (+0.30%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=radish-bdd#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/radish-bdd/radish/pull/421?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=radish-bdd) | Coverage Δ | | |---|---|---| | [radish/compat.py](https://codecov.io/gh/radish-bdd/radish/pull/421/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=radish-bdd#diff-cmFkaXNoL2NvbXBhdC5weQ==) | `85.71% <0.00%> (-14.29%)` | :arrow_down: | | [radish/core.py](https://codecov.io/gh/radish-bdd/radish/pull/421/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=radish-bdd#diff-cmFkaXNoL2NvcmUucHk=) | `100.00% <0.00%> (ø)` | | | [radish/feature.py](https://codecov.io/gh/radish-bdd/radish/pull/421/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=radish-bdd#diff-cmFkaXNoL2ZlYXR1cmUucHk=) | `100.00% <0.00%> (ø)` | | | [radish/matcher.py](https://codecov.io/gh/radish-bdd/radish/pull/421/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=radish-bdd#diff-cmFkaXNoL21hdGNoZXIucHk=) | `100.00% <0.00%> (ø)` | | | [radish/scenario.py](https://codecov.io/gh/radish-bdd/radish/pull/421/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=radish-bdd#diff-cmFkaXNoL3NjZW5hcmlvLnB5) | `100.00% <0.00%> (ø)` | | | [radish/background.py](https://codecov.io/gh/radish-bdd/radish/pull/421/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=radish-bdd#diff-cmFkaXNoL2JhY2tncm91bmQucHk=) | `100.00% <0.00%> (ø)` | | | [radish/scenarioloop.py](https://codecov.io/gh/radish-bdd/radish/pull/421/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=radish-bdd#diff-cmFkaXNoL3NjZW5hcmlvbG9vcC5weQ==) | `100.00% <0.00%> (ø)` | | | [radish/stepregistry.py](https://codecov.io/gh/radish-bdd/radish/pull/421/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=radish-bdd#diff-cmFkaXNoL3N0ZXByZWdpc3RyeS5weQ==) | `100.00% <0.00%> (ø)` | | | [radish/examplescenario.py](https://codecov.io/gh/radish-bdd/radish/pull/421/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=radish-bdd#diff-cmFkaXNoL2V4YW1wbGVzY2VuYXJpby5weQ==) | `100.00% <0.00%> (ø)` | | | [radish/scenariooutline.py](https://codecov.io/gh/radish-bdd/radish/pull/421/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=radish-bdd#diff-cmFkaXNoL3NjZW5hcmlvb3V0bGluZS5weQ==) | `100.00% <0.00%> (ø)` | | | ... and [27 more](https://codecov.io/gh/radish-bdd/radish/pull/421/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=radish-bdd) | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=radish-bdd). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=radish-bdd)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

vchrombie commented 2 years ago

Hi @fliiiix, are you still working on the PR? Please let me know if you are not, I would like to try implementing the tests for the feature. Thanks.

timofurrer commented 2 years ago

@vchrombie the current master branch is the start of an entirely new parser based on an EBNF parser using lark.

AFAIK, currently it wouldn't support multiple tags on a single line, so you'd have to start from scratch there.

vchrombie commented 2 years ago

@timofurrer thanks for the clarification. I'll probably try it. :+1:

fliiiix commented 2 years ago

@vchrombie I think i kinda forgot about this so feel free to take this as a start

from my comments i would guess something worked with this branch but not to sure tbh ^^

fliiiix commented 1 year ago

replaced by https://github.com/radish-bdd/radish/pull/451