Closed jazzsequence closed 12 years ago
From the top of my head and from the error you're getting, sounds like it could be one of two things:
1) The server you're testing on doesn't support outgoing connections. Try a different server/host to test this. 2) Something is misconfigured in how you setup the plugin, and it's still trying to connect to WordPress.org for the updates instead of Github. I did take very quick look at your plugin but couldn't immediately find anything that stood out.
I was originally testing on my local install, so I've uploaded it to a live test server and I'm getting the same thing over there, too. It does seem like it's trying to pull from WP.org...
I'm loading the options array inside an admin_init
hook: https://github.com/jazzsequence/Products/blob/master/products.php#L127
...that wouldn't make a difference, would it? Should I load it inside init
instead?
Again, off the top of my head (sorry, don't have time to further look into this right now), I do think that admin_init might be too late for some reason (patches welcome if you want to fix this). Can you please try with init?
On 2012-08-16, at 4:11 PM, Chris Reynolds notifications@github.com wrote:
I was originally testing on my local install, so I've uploaded it to a live test server and I'm getting the same thing over there, too. It does seem like it's trying to pull from WP.org...
I'm loading the options array inside an admin_init hook: https://github.com/jazzsequence/Products/blob/master/products.php#L127 ...that wouldn't make a difference, would it? Should I load it inside init instead?
— Reply to this email directly or view it on GitHub.
hrm. no dice. tried in init and outside of a function just at the top of the file. Neither worked on either environment (local or live server). It's not a huge, immediate issue. I'd be happy to troubleshoot when you've got time to work on it.
I just switched to @pdclark's gitweb fork and this issue is resolved there. I'm going to close this issue and just use that for now.
further on this issue -- it looks like what's actually resolving the issue is the phpQuery class that @pdclark added to that fork. It's big and when I tried to remove it, I got the same error. So there you go.
cool I'll look into it in the next few days :)
On 2012-08-18, at 3:47 PM, Chris Reynolds notifications@github.com wrote:
further on this issue -- it looks like what's actually resolving the issue is the phpQuery class that @pdclark https://github.com/pdclark added to that fork. It's big and when I tried to remove it, I got the same error. So there you go.
— Reply to this email directly or view it on GitHubhttps://github.com/jkudish/WordPress-GitHub-Plugin-Updater/issues/18#issuecomment-7847431.
Well that is strange and interesting... f/gitweb's first purpose was to load all config from the header, then setup different Git hosts as modular transports, similar to how WP_HTTP works. First I did Github, then Gitweb, which is a generic type of Git hosting.
So, interesting for two reasons:
Are you trying to update from a Git host that uses Gitweb, instead of Github.com?
Currently I'm using it on GitHub, but I have plans on eventually (maybe) using a non-github repo. I looked at the different forks and sort of picked one at random based on the readme and what it added (or simplified) in terms of how the git uri was used. I like having the git uri parameter in the plugin header and using that in addition to the standard Plugin URI, which I wanted to point elsewhere. I actually tried the fork in the first place to see if it would make a difference with the issue with the update details info, and then I tried removing the whole phpQuery class because it's a lot of files and wound up with the same error I started with. Haven't tried with any of the other forks...if it ain't broke...
Interesting. If you remove updater.php lines 186 - 190, it should be safe to remove phpQuery then.
I'll take a look at that & see if it has any effect on the plugin details.
Sent from my iPod http://protocol.by/jazzsequence http://about.me/jazzs3quence
On Aug 18, 2012, at 7:11 PM, Paul Clark notifications@github.com wrote:
Interesting. If you remove updater.php lines 186 - 190, it should be safe to remove phpQuery then.
— Reply to this email directly or view it on GitHub.
When I click on the link (either from the plugins.php or the update-core.php pages) for the details of the update, I get this error in the thickbox:
Any idea how to override/fix this?