search

radishconcepts / WordPress-GitHub-Plugin-Updater

This class is meant to be used with your Github hosted WordPress plugins. The purpose of the class is to allow your WordPress plugin to be updated whenever you push out a new version of your plugin; similarly to the experience users know and love with the WordPress.org plugin repository.
https://github.com/jkudish/WordPress-GitHub-Plugin-Updater
826 stars 193 forks source link

Better ways to handle GitHub API calls and temporary store data #21

Closed coenjacobs closed 12 years ago

coenjacobs commented 12 years ago

Changed a couple things:

  1. Do not delete/recreate transients on page load (debug on) to save your options table indexes. Better to keep their expiration time updated,
  2. Store GitHub data in class instance for future calls so the data only needs to be fetched once per class instance (as get_github_data() method is called twice). This is a little easier on your API calls, especially when you are running in debug mode, when transients are ignored.
jkudish commented 12 years ago

Hey, now that I've merged in #15, your changes no longer apply cleanly. can you please try to revise them?

Thanks! Looks good overall. I especially like the not deleting transients adjustment :)

coenjacobs commented 12 years ago

@jkudish Just merged it and resolved the conflicts. Should be a clean patch now again.