search

radishconcepts / WordPress-GitHub-Plugin-Updater

This class is meant to be used with your Github hosted WordPress plugins. The purpose of the class is to allow your WordPress plugin to be updated whenever you push out a new version of your plugin; similarly to the experience users know and love with the WordPress.org plugin repository.
https://github.com/jkudish/WordPress-GitHub-Plugin-Updater
823 stars 195 forks source link

Code review #27

Closed jkudish closed 8 years ago

jkudish commented 11 years ago

For the next release, I'd like to do a code review and make sure the plugin:

codepress commented 11 years ago

Cool. Saw the update.

On line 117, don't you mean empty() instead of ! empty() ?

Best.

So, far I get Bad Credentials all the time... any thoughts?

T +31 (0) 33 73 70 153 W http://codepress.nl http://www.codepress.nl/

On Mon, Dec 31, 2012 at 11:02 PM, Joachim Kudish notifications@github.comwrote:

For the next release, I'd like to do a code review and make sure the plugin:

  • is secure; make sure it sanitizes, escapes everything properly
  • uses proper WordPress coding standards

  • code is as optimized as possible

    — Reply to this email directly or view it on GitHubhttps://github.com/jkudish/WordPress-GitHub-Plugin-Updater/issues/27.

afragen commented 11 years ago

I think you need to update the readme example to

new WP_GitHub_Updater($config);

jkudish commented 11 years ago

Yup, just haven't gotten around to it yet

On 2013-01-02, at 6:58 PM, Andy Fragen notifications@github.com wrote:

I think you need to update the readme example to

new WP_GitHub_Updater($config);

— Reply to this email directly or view it on GitHub.

afragen commented 11 years ago

BTW, I love the fact that I only need to put my plugin data in the $config and not also in updater.php