search

radishconcepts / WordPress-GitHub-Plugin-Updater

This class is meant to be used with your Github hosted WordPress plugins. The purpose of the class is to allow your WordPress plugin to be updated whenever you push out a new version of your plugin; similarly to the experience users know and love with the WordPress.org plugin repository.
https://github.com/jkudish/WordPress-GitHub-Plugin-Updater
826 stars 193 forks source link

Update placement. #3

Closed thefrosty closed 13 years ago

thefrosty commented 13 years ago

In my plugin I am testing this on, I've got my root directory with a README.md with the proper format version and a folder with the plugin files in with the WordPress readme.txt. Should I move the version format in there and the update variables pointing to the subfolder?

jkudish commented 13 years ago

I haven't tried this with a plugin within a folder.

My first thought is that it won't work out of the box the way you want it to. The reason for that is because when the class processes a download, it unzips the zip file and then extracts into the plugin folder. So in your case you would end up with something like WP_PLUGIN_FOLDER > root_folder > folder_where_your_plugin_actually_lives which I don't believe is supported by WordPress in the first place.

Anyways, you would have to modify the class so that it would work for your particular scenario. I'll consider adding this is an option for the config variables eventually though... or feel free to contribute it ;)

jkudish commented 13 years ago

or of course, you could just move your plugin files into the root of the repo :)

thefrosty commented 13 years ago

Yeah, think I'll do just that, and leave the github markdown readme and SVN WordPress readme..

jkudish commented 13 years ago

That's exactly what I've done on a production plugin which uses this class and it works great :)