search

radishconcepts / WordPress-GitHub-Plugin-Updater

This class is meant to be used with your Github hosted WordPress plugins. The purpose of the class is to allow your WordPress plugin to be updated whenever you push out a new version of your plugin; similarly to the experience users know and love with the WordPress.org plugin repository.
https://github.com/jkudish/WordPress-GitHub-Plugin-Updater
823 stars 195 forks source link

Some updates to test for 1.6 #31

Closed davidmosterd closed 11 years ago

davidmosterd commented 11 years ago

Hi,

Love your idea and execution so far. I have made some enhancements for you to further test. I am new to GitHub so let me know if this has to be done differtently in any way.

Best,

David

jkudish commented 11 years ago

Hey @davidmosterd,

Thank you for these, they mostly look good. A few notes:

Thanks a bunch!

codepress commented 11 years ago

Ah, sorry.

I'm kinda new to GitHub and contributing via it. I will try to make pull requests for each. I made some more changes too which I will try to push.

Thanks.

T +31 (0) 33 73 70 153 W http://codepress.nl http://www.codepress.nl/

On Wed, Jan 2, 2013 at 6:18 PM, Joachim Kudish notifications@github.comwrote:

Hey @davidmosterd https://github.com/davidmosterd,

Thank you for these, they mostly look good. A few notes:

  • I was looking at doing something similar with the single function for making requests
  • Thanks for catching the empty() bug
  • Readme will come later, once we're ready to release 1.6 since people will be relying on it until then.
  • I will gladly test and merge these in, but please create a new issue/pull request for each commit or issue/bug fix, otherwise it's practically impossible for me to merge/test these. I'd also appreciate a descriptive title/description for each issue/pull request you create beyond what's in the commit message. I'll leave it up to you to fix up this up.

Thanks a bunch!

— Reply to this email directly or view it on GitHubhttps://github.com/jkudish/WordPress-GitHub-Plugin-Updater/pull/31#issuecomment-11815862.

davidmosterd commented 11 years ago

I am a bit confused on how to create several pull requests now. Must I branch each commit? And specify what this branch does so you can merge them back into the master tree?

I am willing to do it, just not sure what to do :)

davidmosterd commented 11 years ago

I will branch the requests and the issues accordingly. Sorry for the mess.