search

radishconcepts / WordPress-GitHub-Plugin-Updater

This class is meant to be used with your Github hosted WordPress plugins. The purpose of the class is to allow your WordPress plugin to be updated whenever you push out a new version of your plugin; similarly to the experience users know and love with the WordPress.org plugin repository.
https://github.com/jkudish/WordPress-GitHub-Plugin-Updater
823 stars 195 forks source link

Enhanced get_new_version (depends on #35) #36

Open davidmosterd opened 11 years ago

davidmosterd commented 11 years ago

The check for the version is now just an call to empty() as that should do?

It then assumes 'null' as its default value and tries to get a new version. Which should always work, but if it does not it returns this 'null'

Maybe for better working the fallback should return sooner or the orginal transient should be returned or the 'null' could be converted to ''

Depends on #35. Or we wait for the previous commit.

davidmosterd commented 11 years ago

Coud you/we look into this with some prio? As of now, the current code gives fatal errors when WP_Error is indeed triggered. Regardless of why there is a WP_Error, this really breaks the code badly.