Open dovy opened 11 years ago
One of your plugins or your theme is causing an error, and since you have WP_DEBUG set to true it outputs a warning preventing the normal upgrade redirect. Can you confirm that it is this plugin that is causing the warning?
-Tyrel Kelsey http://ninnypants.com/ http://twitter.com/ninnypants P: 801.477.0481 M: 801.336.7108
On Sat, Jul 13, 2013 at 10:04 AM, Dovy Paukstys notifications@github.comwrote:
I always get this error when trying to authenticate:
Warning: Cannot modify header information - headers already sent by (output started at /home/srain/public_html/wp-admin/includes/template.php:1642) in /home/srain/public_html/wp-includes/pluggable.php on line 876
Any ideas?
— Reply to this email directly or view it on GitHubhttps://github.com/jkudish/WordPress-GitHub-Plugin-Updater/issues/50 .
Just tried on a domain without any plugins installed and one of the base wordpress themes. Same error:
Warning: Cannot modify header information - headers already sent by (output started at /home/srain/public_html/wp-admin/includes/template.php:1642) in /home/srain/public_html/wp-includes/pluggable.php on line 876
On the setup page before I run anything, is here.
Warning: call_user_func() expects parameter 1 to be a valid callback, no array or string given in /home/srain/public_html/wp-admin/includes/template.php on line 1120
Happens on multiple servers. @ninnypants, any ideas?
I'm able to run the test plugin with no issues. Can you run the test plugin on those servers? Other than something being out of date or configured differently I can't think of anything.
@ninnypants Want access to my wordpress install? I'm a little confused. dovy at simplerain dot com.
No I don't like having access to other people's sites.
Just post your configuration code, and the version number of the updater class which is located in the WP_GitHub_Updater
docblock of updater.php
@ninnypants All I did was grab this repo as a zip, load the file, and try to authorize. Nothing else.
Hmm I haven't worked with the OAuth part of the plugin. I believe @pdclark wrote that part and may know what could be happening better than I would. Though If I had to guess it's likely that you haven't set up a github app to authorize with so since you tried to authorize you get warnings when it tries to authorize you during the update.
The oAuth setup can be a bit tricky — I'm not sure what might be causing premature output though (I've not seen that before related to oAuth).
For authentication to work correctly, you do need to make sure your Github app is set up with your WordPress site as the App URL, and I think your WordPress install has to be online and publicly accessible (not development sites, at least for initial authentication).
Once you run the oAuth setup, it should give you a new configuration key to add to the update array.
Which step are you getting hung up on? Can you provide step-by-step instructions to recreate the error (including what you're doing on Github), or a screencast?
What is happening, is the Oauth is trying to redirect after content has been sent to the browser. I moved this line into the class construct and it solved the issue for me, long enough to get the key I needed.
$this->maybe_authorize();
I always get this error when trying to authenticate:
Any ideas?