search

radishconcepts / WordPress-GitHub-Plugin-Updater

This class is meant to be used with your Github hosted WordPress plugins. The purpose of the class is to allow your WordPress plugin to be updated whenever you push out a new version of your plugin; similarly to the experience users know and love with the WordPress.org plugin repository.
https://github.com/jkudish/WordPress-GitHub-Plugin-Updater
822 stars 195 forks source link

Wrap whole class in an if statement instead of just returning void. Fixes #49 #51

Closed ninnypants closed 9 years ago

ninnypants commented 11 years ago

Since it's causing problems on some setups it makes sense to just wrap the whole class in an if statement and let the code continue to execute since nothing else in the file will be executed.

coenjacobs commented 9 years ago

I'd rather not do this as it doesn't really solve the problem in my opinion, but it only makes it slightly harder to read the code. Solving this problem can be done by properly namespacing the class name (which it already does in my opinion) and checking the ABSPATH constant.

Closing this, but still open to discuss it if you want.