search

radius-project / bicep-types-aws

Bicep type support for AWS
Apache License 2.0
7 stars 6 forks source link

Updating type definitions: 4/6/23 #14

Closed willdavsmith closed 1 year ago

willdavsmith commented 1 year ago

Note: I'm doing this because AWS::EC2::VPCEndpoint is included with these changes. This resource could be very useful for us.

Reshrahim commented 1 year ago

Thanks for updating this Will 👍 . We have been wanting to do this for quite some time as new resource types were added to Cloud control. I am curious to know the validations we do/need to do when we update the types. Do we have some tests run? At the minimum having tests on the services we use in our quickstarts/samples (S3, MemoryDB, RDS) are good to start with.

willdavsmith commented 1 year ago

Thanks for updating this Will 👍 . We have been wanting to do this for quite some time as new resource types were added to Cloud control. I am curious to know the validations we do/need to do when we update the types. Do we have some tests run? At the minimum having tests on the services we use in our quickstarts/samples (S3, MemoryDB, RDS) are good to start with.

We have a limited number of tests in the converter, but our functional tests (for the major resources) live in the project-radius/radius repo. I would be interested to see if we could run these tests when we make changes to the AWS type schemas. For now I can do this manually and report back. Any thoughts @rynowak ?

rynowak commented 1 year ago

I think there's an example of a pipeline somewhere that does a cross-repo test. It's pretty involved to run the Radius tests