search

radius-project / dashboard

Frontend experience for Project Radius
15 stars 5 forks source link

add resource breadcrumbs #29

Closed willtsai closed 8 months ago

willtsai commented 8 months ago

Add breadcrumbs to various pages that improves ease of navigation for users.

Introduce a new resource breadcrumbs component to direct link to the parent resources.

example screenshots:

image image image
rynowak commented 8 months ago

I think this is a really nice improvement, but is it the right place in the UI for this?

Most backstage UI includes the breadcrumbs in the header: (See images here) https://github.com/backstage/backstage/issues/3965

If can't do that do, should the breadcrumbs by above the "tabs"?

If we don't like that, then this needs more padding.

willtsai commented 8 months ago

I think this is a really nice improvement, but is it the right place in the UI for this?

Most backstage UI includes the breadcrumbs in the header: (See images here) backstage/backstage#3965

If can't do that do, should the breadcrumbs by above the "tabs"?

If we don't like that, then this needs more padding.

@rynowak Great catch on the appearance of the breadcrumbs. I took a look at the implementation in some of the major Backstage plugins in https://github.com/backstage/backstage/pull/4705, and it looks like the current positioning below "tabs" and above "infocard" is what they've used, so perhaps we can stick with this? I did follow their convention of using <Box> to fix the padding.

image image
rynowak commented 8 months ago

Thanks for checking that, this looks pretty awesome 👍