search

radius-project / dashboard

Frontend experience for Project Radius
13 stars 5 forks source link

feat: filtering of recipe table #74

Closed lechnerc77 closed 4 months ago

lechnerc77 commented 4 months ago

This PR introduces filtering and sorting for the recipe table.

This covers parts of the rquirements from issue #32. The resource table is not yet enabled for sorting and filtering. This requires a bit more work due to the setup of the table.

AB#12039

willtsai commented 4 months ago

Thanks @lechnerc77! We'll take a look at your PR today. cc. @nithyatsu

nithyatsu commented 4 months ago

Thank you so much @lechnerc77, these changes look good. Could you please add a screen shot of the new UI capturing the change?

lechnerc77 commented 4 months ago

@nithyatsu sure I can add screenshots:

Sorting of table

TableSort

Table filter via filter area

TableFilter1

Table Filter via toolbar

TableFilter2

And when looking at the screenshots, there seems to be glitch in the toolbar that leads to a weird padding of the filter section and the title which is cut off. The toolbar is not really configurable, but the padding should imho work out of the box or am I missing something?

nithyatsu commented 4 months ago

@lechnerc77 thank you so much for the screenshots, they look great! I will take a look at the code tomorrow to understand the overlap issue with the text and get back to you.

nithyatsu commented 4 months ago

I did not find a way to get the overlapping text issue solved. But since we are now dropping the toolbar and the title, we should be good.

lechnerc77 commented 4 months ago

I did not find a way to get the overlapping text issue solved. But since we are now dropping the toolbar and the title, we should be good.

Good to hear that I did not overlook something here!