radius-project / radius

Radius is a cloud-native, portable application platform that makes app development easier for teams building cloud-native apps.
https://radapp.io
Apache License 2.0
1.48k stars 94 forks source link

Add pagination support to listing AWS resources from UCP #4123

Open jkotalik opened 2 years ago

jkotalik commented 2 years ago

Overview of feature request

https://github.com/project-radius/radius/blob/main/pkg/ucp/frontend/controller/awsproxy/listawsresources.go#L38

Similar to https://github.com/project-radius/radius/issues/4024, we need to add pagination support to AWS resources as part of the list response. Right now, we will just blindly return the entire list of resources provided to the client, which isn't the desired behavior as we should be able to support a paginated response.

Acceptance criteria

Pagination support is demonstrated from the client side where based on the parameters we decide for amount to paginate, the ARM client can just use the nextLink section to return more data for the list operation: https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/resource-api-reference.md#pagination

Additional context

AB#4318

jkotalik commented 1 year ago