Open sk593 opened 10 months ago
:wave: @sk593 Thanks for filing this issue.
A project maintainer will review this issue and get back to you soon.
We also welcome community contributions! If you would like to pick this item up sooner and submit a pull request, please visit our contribution guidelines and assign this to yourself by commenting "/assign" on this issue.
For more information on our triage process please visit our triage overview
:+1: We've reviewed this issue and have agreed to add it to our backlog. Please subscribe to this issue for notifications, we'll provide updates when we pick it up.
We also welcome community contributions! If you would like to pick this item up sooner and submit a pull request, please visit our contribution guidelines and assign this to yourself by commenting "/assign" on this issue.
For more information on our triage process please visit our triage overview
Engineering Improvement
Area for Improvement (required)
The current workflow for uploading bicep to GHCR has gotten complex, making it susceptible to potential bugs. We should revisit this code to remove redundant code and to improve its readability and maintainability.
Observed behavior (required)
This code specifically has gotten hard to read and debug: https://github.com/radius-project/bicep/blob/3d262311606c3a4a20bcb8dfbbb9679dbd79460a/.github/workflows/radius-build.yml#L295 . There is also some redundant code that could be cleaned up here: https://github.com/radius-project/bicep/blob/bicep-extensibility/.github/scripts/get_release_version.py (this is referenced in #6893).
Desired behavior (required)
We should revisit this code to remove redundant code and to improve its readability and maintainability.
Proposed Fix (optional)
System information
rad Version (required)
Operating system (required)
Additional context
AB#10636