Use typed mocks

[rynowak]

Area for Improvement

We can update our use of gomock to generate typed functions by passing in -typed.

From the command line help:

  -typed
        Generate Type-safe 'Return', 'Do', 'DoAndReturn' function

Observed behavior

We don't pass in -typed so none of the gomock generated code is strongly typed. This slows down development for us, because it's possible to get the wrong signatures.

Desired behavior

Use -typed everywhere we create a mock. This shouldn't break us if we already wrote correct code.

Proposed Fix

• Do a search for //go:generate mockgen. Replace with //go generate mockgen -typed.
• Run make generate-go.
• Run the tests (should work).

rad Version

asdf

Operating system

No response

Additional context

No response

Would you like to support us?

• [ ] Yes, I would like to support you

AB#12367

[radius-triage-bot[bot]]

:wave: @rynowak Thanks for filing this issue.

A project maintainer will review this issue and get back to you soon.

We also welcome community contributions! If you would like to pick this item up sooner and submit a pull request, please visit our contribution guidelines and assign this to yourself by commenting "/assign" on this issue.

For more information on our triage process please visit our triage overview

[radius-triage-bot[bot]]

This issue is a great one to pickup for new contributors. It should only require small changes and not assume a deep knowledge of the Radius architecture.

We always welcome community contributions! If you would like to pick this item up sooner and submit a pull request, please visit our contribution guidelines and assign this to yourself by commenting "/assign" on this issue.

For more information on our triage process please visit our triage overview

[radius-triage-bot[bot]]

:+1: We've reviewed this issue and have agreed to add it to our backlog. Please subscribe to this issue for notifications, we'll provide updates when we pick it up.

We also welcome community contributions! If you would like to pick this item up sooner and submit a pull request, please visit our contribution guidelines and assign this to yourself by commenting "/assign" on this issue.

For more information on our triage process please visit our triage overview

[kachawla]

/assign superbeeny

[kachawla]

@superbeeny could you comment on this with /assign to assign this issue to yourself, since you have a PR for this :)

[superbeeny]

/assign