search

radius-project / radius

Radius is a cloud-native, portable application platform that makes app development easier for teams building cloud-native apps.
https://radapp.io
Apache License 2.0
1.45k stars 92 forks source link

Update to DaprResourceProperties #7919

Open lakshmimsft opened 5 days ago

lakshmimsft commented 5 days ago

Overview of feature request

When recently reviewing a PR (https://github.com/radius-project/radius/pull/7906), we looked at Dapr Component specification, https://github.com/dapr/dapr/blob/9591e5778c4e03587acabe35744770881a86c35f/charts/dapr/crds/components.yaml#L83-L86, and see that fields Metadata, Version, Type are mandatory.

In Radius typespec documentation, https://github.com/radius-project/radius/blob/96fb582125561f3e6d6f1b45c76751cbcf1b8f43/typespec/Applications.Dapr/common.tsp#L27-L35 we treat these as optional fields.

Having reviewed all examples in radius and samples repos, they define these fields, and since we know this specification applies to all Dapr components, creating this issue to review if we should update our model in typespec to required fields or are there compelling reasons to let them be as is today.

Advantages to update: Bicep instellisense will let users know they need to fill out these required fields when describing Dapr components and avoid late errors.

Acceptance criteria

  1. Review decision with team.
  2. If decision is to update model, a. Update typespec model for DaprResourceProperties, run make generate b. Run all unit and functional tests in radius repo c. Ensure tests in samples repo run without issues.

Additional context

No response

Would you like to support us?

AB#13195

radius-triage-bot[bot] commented 5 days ago

:+1: We've reviewed this issue and have agreed to add it to our backlog. Please subscribe to this issue for notifications, we'll provide updates when we pick it up.

We also welcome community contributions! If you would like to pick this item up sooner and submit a pull request, please visit our contribution guidelines and assign this to yourself by commenting "/assign" on this issue.

For more information on our triage process please visit our triage overview