radius-project / radius

Radius is a cloud-native, portable application platform that makes app development easier for teams building cloud-native apps.

https://radapp.io

Apache License 2.0

1.5k stars 97 forks source link

Make main() code consistent #8034

Closed rynowak closed 2 weeks ago

rynowak commented 2 weeks ago

Description

This change updates each entry point of our microservices to the following in a more consistent way.

Use cobra for argument parsing and help.
Accept the configuration file using --config-file as a commandline option.
Use a consistent pattern for choosing the ports used for various purposes.

The port changes only affect local development. In Kuberentes each pod can choose its own listening port without conflict.

Type of change

This pull request is a minor refactor, code cleanup, test improvement, or other maintenance task and doesn't change the functionality of Radius (issue link optional).

Contributor checklist

Please verify that the PR meets the following requirements, where applicable:

[ ] An overview of proposed schema changes is included in a linked GitHub issue.
[ ] A design document PR is created in the design-notes repository, if new APIs are being introduced.
[ ] If applicable, design document has been reviewed and approved by Radius maintainers/approvers.
[ ] A PR for the samples repository is created, if existing samples are affected by the changes in this PR.
[ ] A PR for the documentation repository is created, if the changes in this PR affect the documentation or any user facing updates are made.
[ ] A PR for the recipes repository is created, if existing recipes are affected by the changes in this PR.

radius-functional-tests[bot] commented 2 weeks ago

Radius functional test overview

:mag: Go to test action run

Name	Value
Repository	rynowak/radius
Commit ref	d58209f70422022c4a3420adbee0c92850b031c7
Unique ID	func12914e1c6e
Image tag	pr-func12914e1c6e

Click here to see the list of tools in the current test run

* gotestsum 1.12.0 * KinD: v0.20.0 * Dapr: 1.12.0 * Azure KeyVault CSI driver: 1.4.2 * Azure Workload identity webhook: 1.3.0 * Bicep recipe location `ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/:pr-func12914e1c6e` * Terraform recipe location `http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/.zip` (in cluster) * applications-rp test image location: `ghcr.io/radius-project/dev/applications-rp:pr-func12914e1c6e` * controller test image location: `ghcr.io/radius-project/dev/controller:pr-func12914e1c6e` * ucp test image location: `ghcr.io/radius-project/dev/ucpd:pr-func12914e1c6e` * deployment-engine test image location: `ghcr.io/radius-project/deployment-engine:latest`

Test Status

:hourglass: Building Radius and pushing container images for functional tests... :white_check_mark: Container images build succeeded :hourglass: Publishing Bicep Recipes for functional tests... :white_check_mark: Recipe publishing succeeded :hourglass: Starting ucp-cloud functional tests... :hourglass: Starting corerp-cloud functional tests... :white_check_mark: ucp-cloud functional tests succeeded :white_check_mark: corerp-cloud functional tests succeeded

radius-functional-tests[bot] commented 2 weeks ago

Radius functional test overview

:mag: Go to test action run

Name	Value
Repository	rynowak/radius
Commit ref	15444050f75f0c7a9b4f52a447fbe7cf1e5ac8db
Unique ID	funcb373825d2e
Image tag	pr-funcb373825d2e

Click here to see the list of tools in the current test run

* gotestsum 1.12.0 * KinD: v0.20.0 * Dapr: 1.12.0 * Azure KeyVault CSI driver: 1.4.2 * Azure Workload identity webhook: 1.3.0 * Bicep recipe location `ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/:pr-funcb373825d2e` * Terraform recipe location `http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/.zip` (in cluster) * applications-rp test image location: `ghcr.io/radius-project/dev/applications-rp:pr-funcb373825d2e` * controller test image location: `ghcr.io/radius-project/dev/controller:pr-funcb373825d2e` * ucp test image location: `ghcr.io/radius-project/dev/ucpd:pr-funcb373825d2e` * deployment-engine test image location: `ghcr.io/radius-project/deployment-engine:latest`

Test Status

:hourglass: Building Radius and pushing container images for functional tests... :white_check_mark: Container images build succeeded :hourglass: Publishing Bicep Recipes for functional tests... :white_check_mark: Recipe publishing succeeded :hourglass: Starting corerp-cloud functional tests... :hourglass: Starting ucp-cloud functional tests... :white_check_mark: corerp-cloud functional tests succeeded :white_check_mark: ucp-cloud functional tests succeeded

codecov[bot] commented 2 weeks ago

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 59.08%. Comparing base (59672f4) to head (9afb592). Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
pkg/ucp/server/server.go	0.00%	2 Missing :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #8034 +/- ## ========================================== + Coverage 59.04% 59.08% +0.03% ========================================== Files 567 567 Lines 37728 37726 -2 ========================================== + Hits 22278 22290 +12 + Misses 13897 13887 -10 + Partials 1553 1549 -4 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

radius-functional-tests[bot] commented 2 weeks ago

Radius functional test overview

:mag: Go to test action run

Name	Value
Repository	rynowak/radius
Commit ref	409e7ba0632e289933b30b590a4d578cda25fd27
Unique ID	func195fc98a52
Image tag	pr-func195fc98a52

Click here to see the list of tools in the current test run

* gotestsum 1.12.0 * KinD: v0.20.0 * Dapr: 1.12.0 * Azure KeyVault CSI driver: 1.4.2 * Azure Workload identity webhook: 1.3.0 * Bicep recipe location `ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/:pr-func195fc98a52` * Terraform recipe location `http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/.zip` (in cluster) * applications-rp test image location: `ghcr.io/radius-project/dev/applications-rp:pr-func195fc98a52` * dynamic-rp test image location: `ghcr.io/radius-project/dev/dynamic-rp:pr-func195fc98a52` * controller test image location: `ghcr.io/radius-project/dev/controller:pr-func195fc98a52` * ucp test image location: `ghcr.io/radius-project/dev/ucpd:pr-func195fc98a52` * deployment-engine test image location: `ghcr.io/radius-project/deployment-engine:latest`

Test Status

:hourglass: Building Radius and pushing container images for functional tests... :white_check_mark: Container images build succeeded :hourglass: Publishing Bicep Recipes for functional tests... :white_check_mark: Recipe publishing succeeded :hourglass: Starting corerp-cloud functional tests... :hourglass: Starting ucp-cloud functional tests... :x: Failed to install Radius for corerp-cloud functional test. Please check the logs for more details :x: corerp-cloud functional test failed. Please check the logs for more details :x: ucp-cloud functional test cancelled. Please check the logs for more details

radius-functional-tests[bot] commented 2 weeks ago

Radius functional test overview

:mag: Go to test action run

Name	Value
Repository	rynowak/radius
Commit ref	ac7bc93f1a4ffcae25ca9335e396ece140cdac89
Unique ID	func1fa96abd2e
Image tag	pr-func1fa96abd2e

Click here to see the list of tools in the current test run

* gotestsum 1.12.0 * KinD: v0.20.0 * Dapr: 1.12.0 * Azure KeyVault CSI driver: 1.4.2 * Azure Workload identity webhook: 1.3.0 * Bicep recipe location `ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/:pr-func1fa96abd2e` * Terraform recipe location `http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/.zip` (in cluster) * applications-rp test image location: `ghcr.io/radius-project/dev/applications-rp:pr-func1fa96abd2e` * dynamic-rp test image location: `ghcr.io/radius-project/dev/dynamic-rp:pr-func1fa96abd2e` * controller test image location: `ghcr.io/radius-project/dev/controller:pr-func1fa96abd2e` * ucp test image location: `ghcr.io/radius-project/dev/ucpd:pr-func1fa96abd2e` * deployment-engine test image location: `ghcr.io/radius-project/deployment-engine:latest`

Test Status

:hourglass: Building Radius and pushing container images for functional tests... :white_check_mark: Container images build succeeded :hourglass: Publishing Bicep Recipes for functional tests... :white_check_mark: Recipe publishing succeeded :hourglass: Starting ucp-cloud functional tests... :hourglass: Starting corerp-cloud functional tests... :x: Failed to install Radius for ucp-cloud functional test. Please check the logs for more details :x: ucp-cloud functional test failed. Please check the logs for more details :x: corerp-cloud functional test cancelled. Please check the logs for more details

radius-functional-tests[bot] commented 2 weeks ago

Radius functional test overview

:mag: Go to test action run

Name	Value
Repository	rynowak/radius
Commit ref	9afb59224d56ebbcfff0dd4ecced81b17940af8a
Unique ID	func5ce26f194a
Image tag	pr-func5ce26f194a

Click here to see the list of tools in the current test run

* gotestsum 1.12.0 * KinD: v0.20.0 * Dapr: 1.12.0 * Azure KeyVault CSI driver: 1.4.2 * Azure Workload identity webhook: 1.3.0 * Bicep recipe location `ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/:pr-func5ce26f194a` * Terraform recipe location `http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/.zip` (in cluster) * applications-rp test image location: `ghcr.io/radius-project/dev/applications-rp:pr-func5ce26f194a` * dynamic-rp test image location: `ghcr.io/radius-project/dev/dynamic-rp:pr-func5ce26f194a` * controller test image location: `ghcr.io/radius-project/dev/controller:pr-func5ce26f194a` * ucp test image location: `ghcr.io/radius-project/dev/ucpd:pr-func5ce26f194a` * deployment-engine test image location: `ghcr.io/radius-project/deployment-engine:latest`

Test Status

:hourglass: Building Radius and pushing container images for functional tests... :white_check_mark: Container images build succeeded :hourglass: Publishing Bicep Recipes for functional tests... :white_check_mark: Recipe publishing succeeded :hourglass: Starting corerp-cloud functional tests... :hourglass: Starting ucp-cloud functional tests... :white_check_mark: ucp-cloud functional tests succeeded :white_check_mark: corerp-cloud functional tests succeeded