radix-ui / icons

A crisp set of 15×15 icons designed by the @workos team.
https://radix-ui.com/icons
MIT License
2.12k stars 104 forks source link

fix: Use `Object.defineProperty` to assign the `__esModule` flag #145

Closed shuding closed 1 year ago

shuding commented 1 year ago

This PR changes the direct assignment module.exports.__esModule = true to use Object.defineProperty instead, as the __esModule is usually considered as a read only key and that assignment will cause errors in many bundlers including Webpack. One example: https://github.com/facebook/create-react-app/issues/2602.


PR checklist:

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
radix-icons ❌ Failed (Inspect) Nov 25, 2022 at 1:23PM (UTC)
heikir commented 1 year ago

@kandji-joe Is there an ETA when this fix will be merged?

asherccohen commented 1 year ago

Nice that you're addressing this, any ETA?