add react 19 to peer deps

[jaredcbaum]

This PR:

• Adds React 19 to peer reps for the icons package

[mxa0079]

Please merge

[officiallerio]

please merge

[roelfjan]

Merging this is one small step for a man, one giant leap for the community!

[takefy-dev]

Please merge it omg

[codenomnom]

Uhm, is there any issue merging this? 🤔

[takefy-dev]

bro is just AFKOn 24 Oct 2024, at 12:56, codenomnom @.***> wrote: Uhm, is there any issue merging this? 🤔

—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you commented.Message ID: @.***>

[onurhan1337]

great work.

[Gitstar-OC]

Please merge it ?

[needim]

you can use overrides for a temporary fix.

"overrides": {
    "@radix-ui/react-icons": {
        "react": "$react"
    }
}

also overrides are needed for other libraries also, maybe define your overrides like this:

"overrides": {
    "react": "$react",
    "react-dom": "$react-dom"
}

[!WARNING]
This is just a temporary fix!

[shadcn]

friendly bump here. can we merge? any blockers?

[rezarahem]

This should have been merged already. No issues here.

[takefy-dev]

the owner is AFK he is not working at radix anymore

[VibingCreator]

Merge you tyrant.

[guchris]

is there someone we can contact?

[officiallerio]

is there someone we can contact?

the other stupid way we can do is by making nonsense PR on all radix repo by saying "merge the radix icons" for them to notice us

[Bantolinao]

please merge! why it take too long

[DysektAI]

Merge please, so the actual issues can be fixed...

[Scholar01]

https://github.com/radix-ui/primitives/issues/3195 I went to another library and raised an issue

[priyeshghamandi]

Please merge

[DariusLukasukas]

Is this repo still maintained? Shadcn UI compatibility is blocked due to the pending Radix icons merge.

[takefy-dev]

No it’s not

On 26 Oct 2024, at 20:08, Darius Lukasukas @.***> wrote:

Is this repo still maintained? Shadcn UI compatibility is blocked due to the pending Radix icons merge.

— Reply to this email directly, view it on GitHub https://github.com/radix-ui/icons/pull/184#issuecomment-2439678947, or unsubscribe https://github.com/notifications/unsubscribe-auth/ATANFWLBNTIKPV2MYR4PUOLZ5PLBNAVCNFSM6AAAAABNDCWC2OVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMZZGY3TQOJUG4. You are receiving this because you commented.

[hsavit1]

cmon please merge this already

[Saptak-Bose]

merge this plsss...shadcn not working cause of this

[officiallerio]

try to put issues on other radix repo so that they will notice us.

[hackerharsh-77]

pl merge this as it is causing version mismatch in frameworks react 19^

[radioac7iv3]

Looks good to me, can we merge?

[officiallerio]

merge

[Gitstar-OC]

Please Merge @chaance and @hadihallak !!

[shadowoff09]

Please merge it, shadcn is broken because of this.

[officiallerio]

@chaance @hadihallak please merge sir

[priyeshghamandi]

@chaance @hadihallak can you please merge this PR. It's blocking a lot of projects. Thanks,

[tyrellshawn]

@chaance @hadihallak Please merge its blocking

[madebydor]

merge it for the love of shadcn @chaance @hadihallak

[officiallerio]

:(

[priyeshghamandi]

@vladyslavmoroz @colmtuite @peduarte @loklaan can you please merge this PR. It's blocking a lot of projects. Thanks,

[napstar-420]

Please merge it man...., i can't init the shadcn ui

[diegohaz]

I don't understand. Couldn't you just npm install --force while waiting for this?

[peduarte]