Closed feute closed 2 years ago
This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.
🔍 Inspect: https://vercel.com/modulz/radix-icons/2gwuZcVaBRNhoUE4mwEev2uzcek2
✅ Preview: https://radix-icons-git-fork-feute-bookmark-filled-icon.modulz-deploys.com
Hey, thanks for the contribution. Sorry for the delay, I'll have a chance to check it out later this week.
Hello, I wanted to contribute by adding a simple "filled" variant for the bookmark icon. All I did was to copy the Figma file to be able to edit it, then I mimicked the filled variant of the sewing pin related to its normal "unfilled" state, i.e., duplicating the icon shape and using a fill instead of a stroke.
I'd like to get some feedback to see if this is the right way to do it, and if I can do more, since all I did (or could do) was to add the SVG, the React component, and added it to the website; I guess there's more I'm missing, since there's an IconJar, a zip, and a Sketch file, but I couldn't figure out how to update them accordingly (and I don't even have Sketch), so I guess it's not up to me.
If this is this easy I'd like to discuss and contribute to more icon variants if this goes through at the end.
This closes #95
PR checklist:
width="15" height="15" viewBox="0 0 15 15"
stroke
clip-path