search

radix-ui / themes

Radix Themes is an open-source component library optimized for fast development, easy maintenance, and accessibility. Maintained by @workos.
https://radix-ui.com/themes
MIT License
5.33k stars 190 forks source link

Added responsive styles for `grid-area` #569

Closed benmarch closed 3 days ago

benmarch commented 1 month ago

Description

The documentation for the gridArea layout prop indicates that it is responsive, but I noticed that the responsive styles were not working for me. This adds the classes needed to make the gridArea prop responsive.

Testing steps

I added an additional example to the grid-area playground example that uses responsive values for grid-area. These specific values ensure that the responsive styles work correctly because without the styles, the Card's body text only spans a single column.

Relates issues / PRs

vercel[bot] commented 1 month ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
themes-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 26, 2024 9:43pm
benmarch commented 2 weeks ago

hey @vladmoroz, sorry to bug you, but do you think this is ok to be merged soon? Also happy to make changes if you'd like to see this set up differently. Thanks!

chaance commented 3 days ago

Hey @benmarch, I'm catching up on some old PRs and I'd like to merge this for the next release. Do you mind adding a changelog entry for 3.1.5 and add a short bullet?

benmarch commented 3 days ago

All set! Thanks, @chaance, much appreciated!