radix-ui / website

Website and documentation for Radix.
https://radix-ui.com
MIT License
840 stars 445 forks source link

Add styles to "indeterminate" checkbox example #166

Closed smhutch closed 2 years ago

smhutch commented 3 years ago

Documentation

The example shown below doesn't have any visual change when toggling the indeterminate state.

CleanShot 2021-05-25 at 16 44 00@2x

My suggestion would be to show an indeterminate state, similar to this:

CleanShot 2021-05-25 at 16 46 25@2x

Relevant Radix Component(s)

Checkbox

Examples from other doc sites

n/a

jjenzz commented 3 years ago

@smhutch Thanks for raising this. It appears there are a few issues with the dark theme in our docs as I can see the indeterminate state is fine in the light theme:

image

I'm transferring this issue to the @radix-ui/website repo as it's not an issue with the primitives themselves.

Thanks again 👍

benoitgrelard commented 3 years ago

This will be fixed soon once we overall the styling after our colors are released as mentioned here: https://github.com/radix-ui/website/issues/165#issuecomment-846481397

benoitgrelard commented 2 years ago

This has been resolved.