radix-ui / website

Website and documentation for Radix.
https://radix-ui.com
MIT License
840 stars 445 forks source link

Pages sometimes load without styles for a split second #189

Closed jjenzz closed 2 years ago

jjenzz commented 3 years ago

I know we've been aware of this for some time but wanted to get it written down.

It seems we're depending on @modulz/design-system here so we're on a really old version of stitches. I'm guessing that might have something to do with it.

It would be good to upgrade to @radix-ui/design-system if possible.

peduarte commented 3 years ago

@jjenzz hmm, the DS is already using the latest version of Stitches. How often are you seeing this?

jjenzz commented 3 years ago

@peduarte yes the @radix-ui/design-system is using the latest version but we're using @modulz/design-system for the website which is still using stitches canary.

I'm suggesting this change:

- @modulz/design-system
+ @radix-ui/design-system
peduarte commented 3 years ago

What is @radix-ui/design-system? There's no such package

Stitches 0.2.0 is available from @modulz/design-system@0.3.0

But that also comes with lots of breaking changes. Colors, API, components, etc.

This is all happening in this PR: https://github.com/radix-ui/website/pull/160

jjenzz commented 3 years ago

I know I've got the 'rona but please don't make me feel insane 😩😅 you committed to that repo 25 minutes ago https://github.com/radix-ui/design-system

I assumed that's the one we need as the package.json there has the latest stitches. This repo is using @modulz/design-system which depends on canary and has been archived.

image

jjenzz commented 3 years ago

Oh i see the confusion here, we have a repo with a mismatched package name. Well that's hella confusing.

In that case I don't know what's causing the bug but the report still stands. I get a real noticeable flash of unstyled content in the docs.

peduarte commented 3 years ago

Oh 🤣 yeah, I see why it's confusing. We haven't renamed the package name yet - on purpose.

Let's leave this on, it will be solved when the PR is merged 👍

benoitgrelard commented 2 years ago

This has been resolved.