Docs(accordion): fix aria-hidden attribute in examples

radix-vue / radix-vue

Vue port of Radix UI Primitives. An open-source UI component library for building high-quality, accessible design systems and web apps.

https://radix-vue.com

MIT License

2.77k stars 149 forks source link

Docs(accordion): fix aria-hidden attribute in examples #888

Closed dwightjack closed 1 month ago

dwightjack commented 1 month ago

This PR is not related to radix-vue itself, but to the usage of @iconify/vue.

@iconify/vue already adds aria-hidden by default, but if we set the aria-hidden attribute without any value, this check will remove it completely, leaving a role="img" without name.

If this change is fine and I didn't miss anything, I can submit another to update other examples where we used the attribute on the Icon component.

zernonia commented 1 month ago

Thanks for picking this up @dwightjack ! Can you update other similar changes in this PR too? 😁

dwightjack commented 1 month ago

Thanks for picking this up @dwightjack ! Can you update other similar changes in this PR too? 😁

@zernonia Sure! I removed every other similar instance in https://github.com/radix-vue/radix-vue/pull/888/commits/617bea561035f538cf481266a009546f893f52b2.

zernonia commented 1 month ago

Really appreciate the PR @dwightjack ! Good job! 💚🚀