search

radix-vue / radix-vue

Vue port of Radix UI Primitives. An open-source UI component library for building high-quality, accessible design systems and web apps.
https://radix-vue.com
MIT License
2.77k stars 149 forks source link

feat: focus trigger on dialog close #922

Closed enkot closed 2 weeks ago

enkot commented 2 weeks ago

Closes #921

Adds a triggerElement prop to the DialogRoot so that the user can specify which trigger was used to open the dialog.

zernonia commented 2 weeks ago

@enkot would you want to try implement the suggestion here (https://github.com/radix-vue/radix-vue/issues/921#issuecomment-2112137722)? Or you want to close this so others can tackle it 😁

enkot commented 2 weeks ago

Let me try 🙂

enkot commented 2 weeks ago

@zernonia Could you please check? Looks like this small change is enough 👀 https://github.com/radix-vue/radix-vue/pull/922/files#diff-35b87a2b4068c507f392e516b0210472850836e523e8e42c279c3db0f0da45fbR55

enkot commented 2 weeks ago

Thanks for the PR @enkot ! I've push some minor stuff yaaa 😁

Thank you!) 💚