fix: delegatedProps type error on Checkbox

JoeyMckenzie commented 1 month ago

🔗 Linked issue

Similar to https://github.com/radix-vue/shadcn-vue/issues/574, Checkbox was also having the same compile errors due to type mismatch on delegatedProps. Just noticed it working on a new project and pulling in the latest version of the component.

❓ Type of change

[ ] 📖 Documentation (updates to the documentation, readme or JSdoc annotations)
[x] 🐞 Bug fix (a non-breaking change that fixes an issue)
[ ] 👌 Enhancement (improving an existing functionality like performance)
[ ] ✨ New feature (a non-breaking change that adds functionality)
[ ] 🧹 Chore (updates to the build process or auxiliary tools and libraries)
[ ] ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

📸 Screenshots (if appropriate)

📝 Checklist

[ ] I have linked an issue or discussion.
[ ] I have updated the documentation accordingly.

sadeghbarati commented 1 month ago

Based on Zernonia's comment,useForward... functions will accept ComputedRef or Ref for delegatedProps

If you have type error, this should be resolved after 1.8.1

JoeyMckenzie commented 1 month ago

Ah good to know. Thank you!

sadeghbarati commented 1 month ago

Related PR in radix-vue https://github.com/radix-vue/radix-vue/pull/943

Can you test this and see if type error is gone or not, thanks

npm i https://pkg.pr.new/radix-vue@943

zernonia commented 1 month ago

Yeah there was a type error in v.1.8.0. As @sadeghbarati pointed out, https://github.com/radix-vue/radix-vue/pull/943 should fix this issue

JoeyMckenzie commented 1 month ago

Yep, fixed with the new version. Thank you! Closing this PR.

radix-vue / shadcn-vue