radix-vue / shadcn-vue

Vue port of shadcn-ui
https://www.shadcn-vue.com/
MIT License
4.55k stars 261 forks source link

[Bug]: DonutChart's legend is not shown #577

Open Nonolanlan1007 opened 4 months ago

Nonolanlan1007 commented 4 months ago

Reproduction

https://stackblitz.com/edit/vitejs-vite-bmzqsu

Describe the bug

The documentation indicate a prop named "showLegend", but it does do anything

System Info

System:
    OS: Windows 11 10.0.22631
    CPU: (16) x64 AMD Ryzen 7 5700G with Radeon Graphics         
    Memory: 1.34 GB / 15.30 GB
  Binaries:
    Node: 20.10.0 - C:\Program Files\nodejs\node.EXE
    npm: 10.2.3 - C:\Program Files\nodejs\npm.CMD
  Browsers:
    Edge: Chromium (123.0.2420.97)
    Internet Explorer: 11.0.22621.3527
  npmPackages:
    @vueuse/core: ^10.9.0 => 10.9.0 
    radix-vue: ^1.8.0 => 1.8.0
    vue: ^3.4.21 => 3.4.27

Contributes

zernonia commented 4 months ago

Thanks @Nonolanlan1007 ! Yeah you are right. There's no legend for DonutChart. We should remove it

Nonolanlan1007 commented 4 months ago

So this issue will be converted into a feature request 😅

Can you add a legend to the DonutChart?

zernonia commented 4 months ago

Ah yes! Something like this ya?

image

Nonolanlan1007 commented 4 months ago

Yep, that's pretty good!

setyawannn commented 3 weeks ago

is the legend feature available for now?