fix: change label/value order in tasks priorities data

radix-vue / shadcn-vue

Vue port of shadcn-ui

https://www.shadcn-vue.com/

MIT License

3.51k stars 203 forks source link

fix: change label/value order in tasks priorities data #603

Closed pereira0x closed 2 weeks ago

pereira0x commented 2 weeks ago

🔗 Linked issue

❓ Type of change

[ ] 📖 Documentation (updates to the documentation, readme or JSdoc annotations)
[x] 🐞 Bug fix (a non-breaking change that fixes an issue)
[ ] 👌 Enhancement (improving an existing functionality like performance)
[ ] ✨ New feature (a non-breaking change that adds functionality)
[ ] 🧹 Chore (updates to the build process or auxiliary tools and libraries)
[ ] ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

This PR addresses and resolves an inconsistency in the data of the task example, ensuring that priority attributes follow the same order as labels and statuses attributes.

📸 Screenshots (if appropriate)

📝 Checklist

[ ] I have linked an issue or discussion.
[ ] I have updated the documentation accordingly.

sadeghbarati commented 2 weeks ago

Hi, can you explain more or record a video of this inconsistency?

pereira0x commented 2 weeks ago

Hey, here you go: In both labels and statuses, the order of their attributes is value first, then label.

In priorities, the label comes first, then it's the value:

I believe it would be nice to use the same order in all of them.

sadeghbarati commented 2 weeks ago

I get it now, but it's not that important right? we should add eslint rule to sort them in alphabetical order