Open MuhammadM1998 opened 1 week ago
@sadeghbarati Tests are passing but can you help confirming everything works as expected π
Sure, I appreciate the effort you put into β€οΈβπ₯
Will test tomorrow π
https://stackblitz.com/edit/vitejs-vite-1fjqkm?file=package.json
@MuhammadM1998 Sry for the late test, I tested the CLI the seems to have problem with the add
command
init
command is working well but add command still repeat the init
command even though the component.json
is exists
Thanks for testing π I'll see whats wrong and retest
@sadeghbarati It was always running promptForConfig
which should only run in init
. It's fixed now and running as expected.
π Linked issue
570
β Type of change
π Description
POC of #570. This PR just extracts the vue-specific code
init
,add
,diff
commands into their respective commands incommands/frameworks/vue
folder and update the imports accordingly. No other changes were made for easier reviewing.Remarks:
getConfig
has been extracted to its separate file too because in the Nuxt module we'd read the config differently (think reading components config from nuxt.config instead of components.json). Hence it's extracted to a reusable function to be used in all commands when needed.vue
commands fornuxt
to ensure everything works as expected. Next step is creating nuxt-specific commands and use those instead.πΈ Screenshots (if appropriate)
π Checklist