zernonia commented 1 week ago

🔗 Linked issue

❓ Type of change

[ ] 📖 Documentation (updates to the documentation, readme or JSdoc annotations)
[ ] 🐞 Bug fix (a non-breaking change that fixes an issue)
[ ] 👌 Enhancement (improving an existing functionality like performance)
[x] ✨ New feature (a non-breaking change that adds functionality)
[ ] 🧹 Chore (updates to the build process or auxiliary tools and libraries)
[ ] ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

📸 Screenshots (if appropriate)

📝 Checklist

[ ] I have linked an issue or discussion.
[ ] I have updated the documentation accordingly.

zernonia commented 1 week ago

@sadeghbarati there was some problem back then when I'm implementing the tw prefix, but I just had a look today and seems like the snapshot and everything looks good. Can you help review and check if it's all good? 😁

sadeghbarati commented 1 week ago

Just switch to your branch build the CLI and upload it to Stackblitz, seems not working yet, which is why I don't like test files 😆

https://stackblitz.com/edit/vitejs-vite-dzqk4g

zernonia commented 1 week ago

Can you check again @sadeghbarati ? 😁

sadeghbarati commented 1 week ago

@zernonia fix: cater for cn function did fixed the cn prefix

I see prefix applied to all imports in all ui .ts files https://stackblitz.com/edit/vitejs-vite-dzqk4g

zernonia commented 1 week ago

Ahh nice catch @sadeghbarati ! Fixing!!!!

sadeghbarati commented 1 week ago

I think we should setup pkg.pr.new for shadcn-vue cli and module packages too, Stackblitz upload limit will prevent me to test future PRs

zernonia commented 1 week ago

Yeah we can do that.. that would really help to test out the PR 😁

github-actions[bot] commented 1 week ago

Deploying with Cloudflare Pages

Name	Result
Last commit:	`b88fe615`
Status:	✅ Deploy successful!
Preview URL:	https://473d1d70.shadcn-vue.pages.dev
Branch Preview URL:	https://refs-pull-619-merge.shadcn-vue.pages.dev

zernonia commented 1 week ago

Yup not as easy as I thought hahaha.. usingStringLiteral is not powerful enough.. will convert to draft for now

zernonia commented 1 week ago

@sadeghbarati I found this goldmind! https://vue-metamorph.dev/

It simplified the transformation soooooo much!!! I've refactor the transformer entirely to use vue-metamorph! Do help test it out ya!

sadeghbarati commented 1 week ago

I hit the upload limit 😭

I think vue-metamorph should be in dependencies

These tests are in TypeScript project

Button `index.ts`

All UI ts files import are still prefixed

CVA defaultVariants has issue with prefixes (this is not just in the button, the component that is using CVA is having this issue)
interface types/props also have the same issue
withDefaults also has the same issue

`Button.vue`

`auto-form`, `chart-area|bar|donut|line`

sadeghbarati commented 1 week ago

Now I understand why Codemod Team is having hard time working on Vue Codemods

sadeghbarati commented 1 week ago

Tested JavaScript projects too, seems like detypes is not working well with vue-metamorph

Button `index.js`

zernonia commented 1 week ago

@sadeghbarati Do you mind checking again? This time the transformation for prefix is much stricter to paritcular attributes and function only.

Also made a patch for vue-eslint-parser that vue-metamorph is using underneath. The undefined issue should be gone now

sadeghbarati commented 1 week ago

@zernonia Everything is fine just

/* METAMORPH_START */ comment is in the some of components after parsing
sonner toast-options classes in not having the prefixes (ignore defineProps error I just add the components for test)
v-calendar style section is not having the prefix which we could ignore duo to legacy package and new calendar implementation

sadeghbarati commented 1 week ago

in JavaScript projects, found a strange thing, happening in AccordionTrigger and SelectItem and maybe other components as well

cn placement is not formatted and also an additional ] is added to the end of the cn function

sadeghbarati commented 1 week ago

in JavaScript projects, found a strange thing, happening in AccordionTrigger and SelectItem and maybe other components as well

cn placement is not formatted and also an additional ] is added to the end of the cn function

Looks like this is detypes bug not vue-metamorph

radix-vue / shadcn-vue

Tailwind prefix #619

🔗 Linked issue

❓ Type of change

📚 Description

📸 Screenshots (if appropriate)

📝 Checklist

Deploying with Cloudflare Pages

These tests are in TypeScript project

Button `index.ts`

`Button.vue`

`auto-form`, `chart-area|bar|donut|line`

Button `index.js`

radix-vue / shadcn-vue

Tailwind prefix #619

🔗 Linked issue

❓ Type of change

📚 Description

📸 Screenshots (if appropriate)

📝 Checklist

Deploying with Cloudflare Pages

These tests are in TypeScript project

Button index.ts

Button.vue

auto-form, chart-area|bar|donut|line

Button index.js

Button `index.ts`

`Button.vue`

`auto-form`, `chart-area|bar|donut|line`

Button `index.js`