radix-vue / shadcn-vue

Vue port of shadcn-ui
https://www.shadcn-vue.com/
MIT License
3.51k stars 203 forks source link

fix: make NumberField more flexible (#613) #623

Closed hsellik closed 1 week ago

hsellik commented 1 week ago

๐Ÿ”— Linked issue

613

โ“ Type of change

๐Ÿ“š Description

Change the NumberField, so it could be used in different configurations without extra effort from the developer. Resolves #613

๐Ÿ“ธ Screenshots (if appropriate)

Before: image image

After: image image

๐Ÿ“ Checklist

sadeghbarati commented 1 week ago

@hsellik Thanks Man ๐Ÿ™Œ

Can you run pnpm build:registry in apps/www

hsellik commented 1 week ago

Oh, missed that one, pushed it now. The pnpm build:registry wants to remove empty lines at the end of the files for some reason, don't know if it's just my setup.

sadeghbarati commented 1 week ago

Will checkout to your branch tomorrow to push some changes if you don't mind ๐Ÿ™Œ

Cause using p-2.5 is not good imo

sadeghbarati commented 1 week ago

You were using the ring and focus stuff on div element in NumberFieldContent.vue which is not the best practice

The idea of data-slot is from tailwindui Catalyst template