[Bug]: The Carousel element performance presented on www.shadcn-vue.com is different from the one on ui.shadcn.com

radix-vue / shadcn-vue

Vue port of shadcn-ui

https://www.shadcn-vue.com/

MIT License

4.12k stars 237 forks source link

[Bug]: The Carousel element performance presented on www.shadcn-vue.com is different from the one on ui.shadcn.com #658

Closed michaelprys closed 1 month ago

michaelprys commented 1 month ago

Reproduction

1) https://www.shadcn-vue.com/docs/components/carousel.html, 2) https://ui.shadcn.com/docs/components/carousel

Describe the bug

If you go to https://www.shadcn-vue.com/docs/components/carousel.html you'll notice that the carousels are laggy compared to the ones on https://ui.shadcn.com/docs/components/carousel.

System Info

No output needed for this issue.

Contributes

[ ] I am willing to submit a PR to fix this issue
[ ] I am willing to submit a PR with failing tests

sadeghbarati commented 1 month ago

I don't sense the laggy carousel on my end, maybe it could be resolved after this PR gets released

https://github.com/davidjerleke/embla-carousel/pull/929

davidjerleke commented 1 month ago

@michaelprys, @sadeghbarati the jitter was accidentally introduced in v8.1.6 and has been resolved in v8.1.7. Please bump all Embla versions (including plugins) here in the code to 8.1.7.

Issue: https://github.com/davidjerleke/embla-carousel/issues/928
PR that solves the problem: https://github.com/davidjerleke/embla-carousel/pull/933

Best, David

sadeghbarati commented 1 month ago

Thanks, David for explaining in such detail ❤️

Yes, the issue is solved in 8.1.7

michaelprys commented 1 month ago

@davidjerleke Perfect, thank you for the reply!