search

radix-vue / vaul-vue

An unstyled drawer component for Vue.
https://vaul.unovue.com
145 stars 6 forks source link

Rebuild #23

Closed Elliot-Alexander closed 4 months ago

Elliot-Alexander commented 4 months ago

Restructured a huge chunk of the controls and Drawer Root to make things more readable and more 'Vue' flavoured.

Currently running into a big issue with the controlled (and the types of controlled) vs uncontrolled. The test case to compare between this and the original package is the controlled test in the playwright tests through playground.

Would definitely be open to any help on this one.

zernonia commented 4 months ago

Thanks for the PR @Elliot-Alexander ! Looking at this PR today! 😁

cloudflare-pages[bot] commented 4 months ago

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: a058285
Status: ✅  Deploy successful!
Preview URL: https://84811f97.vaul-vue.pages.dev
Branch Preview URL: https://rebuild.vaul-vue.pages.dev

View logs

zernonia commented 4 months ago

@Elliot-Alexander I've made 'some' changes 😂 and seems like all the tests are passing now. (temporary hide webkit as there's some weird behavior with 1 of the test).

Let me know if the above fixes the

big issue with the controlled (and the types of controlled) vs uncontrolled.

you mentioned earlier.

zernonia commented 4 months ago

@Elliot-Alexander Nicely done on making it closer to Vue DX. I will merge this in for now ya!