search

radixdlt / olympia-node

Radix monorepo
Other
142 stars 35 forks source link

[DO-122] Enable parallel run on integration tests #549

Closed muzuke closed 2 years ago

sonarcloud[bot] commented 2 years ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

muzuke commented 2 years ago

This doesn't seem to have any effect. The build times are the same with previous runs.

muzuke commented 2 years ago

@Theoklitos @diegomrsantos Is there any other way to run the integrations tests in parallel?

diegomrsantos commented 2 years ago

@muzuke they already run in parallel, it is probably not reflected on CI cause it is configured to use half of available cores, so we need at least 4 to see any difference.

muzuke commented 2 years ago

@diegomrsantos Is there anything that can be done on the CI configuration to leverage more cores? Or should I close this PR?

diegomrsantos commented 2 years ago

@muzuke I think @rvelaz mentioned one day that we will need to have our own runners for that.

rvelaz commented 2 years ago

We can merge the change, but it won't have any effect until we use different runners

diegomrsantos commented 2 years ago

Is this change necessary?

diegomrsantos commented 2 years ago

Can we close this pr?