search

radixdlt / radixdlt-java

A Java/Android Client library for interacting with a RADIX Distributed Ledger.
MIT License
75 stars 16 forks source link

Client PoW Configurability #266

Closed lfeagan closed 4 years ago

lfeagan commented 4 years ago

Hi, I am trying to do some client-based benchmarking. On the server-side, I can disable PoW with "debug.nopow". However, the client has a fixed value of 16 to compute the PoW. This inherently limits a client to around 17 tps per core. I understand why this setting is here for a public network, but for benchmarking or a private network this seems unnecessary. What are your thoughts on adding configurability to disable PoW or configure the # of leading bits. Should the client inquire with the server to determine the # of required bits after connecting? If done via client config, should it be via a file similar to default.config on the server or via the BootstrapConfig-->RadixUniverseConfig class? My personal thoughts are that the client should inquire with the server as it is the server that sets and enforces the rules. Thanks, Lance

talekhinezh commented 4 years ago

We actually have plans on removing the POW fee relatively soon. If this was to be kept as a configuration parameter though, yes this information would likely be kept somewhere in the genesis atom which effectively acts as the application configuration data shared by both server and client.

lfeagan commented 4 years ago

Thanks for quick reply. As it sounds like you are already working address this I am going to close this issue.