radj307 / volume-control

Specific-Application Volume Control Hotkeys for Windows.
https://radj307.github.io/volume-control
GNU General Public License v3.0
78 stars 8 forks source link

[BUG] 6.5.1 installer - copyright message with wrong © character #115

Closed bovirus closed 12 months ago

bovirus commented 12 months ago

Version Number

6.5.1

File

Installer (VolumeControl-Installer.exe)

Windows Version

Windows 10 22H2 64bit Italian

Actual Behaviour

In installer exe file properties in Copyright string there is a wrong charcater (already reported in rpevious version).

image

to avoid this issue instead "©" use "(c)"

Expected Behaviour

Remove not necessary character

Reproduction Steps

Right click on installer exe file -> Properties

Log

No response

radj307 commented 12 months ago

This is caused by an encoding issue on the github actions runner, not an issue with the character itself. No need for a workaround, this can be fixed.

Unicode has multiple different encodings. UTF-8 is the standard that should be used everywhere by default. For reasons that only Microsoft would know, they decided to use UTF-16 in Windows.

© (U+00A9) is encoded as 0x00A9 in UTF-16 and 0xC2 0xA9 in UTF-8. If you try to load it with UTF-16 it can get misinterpreted as separate characters: 0x00C2 0x00A9, or ©.

I suspect this is due to vcsetup.iss being saved in UTF-8 without BOM (byte order marks), so Windows decided to mangle it into UTF-16 to make life just a little bit harder.

radj307 commented 12 months ago

Saved vcsetup.iss in UTF-8 with BOM in b231d08985bea935ba2f84c23df070af6754699b. Will test.

radj307 commented 12 months ago

Success!
image

bovirus commented 12 months ago

@radj307

Thanks. Please close the ticket.