radj307 / volume-control

Specific-Application Volume Control Hotkeys for Windows.
https://radj307.github.io/volume-control
GNU General Public License v3.0
72 stars 6 forks source link

Fix multiple sessions per process #162

Open Dregu opened 6 months ago

Dregu commented 6 months ago

When routing the W10 per-app audio output to a non-default device, some applications will open (inactive) sessions to multiple devices. Or some complex apps might do so on purpose. VC treats these sessions as duplicates even though they are on different outputs, which means only the first session can be adjusted, and it's usually the wrong one.

So I fixed that...

This PR:

Haven't tested this a lot, just what I have running currently, but then again there's not much to test. I also don't really know what I'm doing, so I might be doing something silly.

image Some more clutter in the mixer, but not in the notification!

Dregu commented 6 months ago

I also have a branch messing with active application / target override notifications where all affected sessions are always shown, even if the sessions are otherwise hidden. I had to reorganize how the hidden sessions are stored and filtered though, cause it seemed like a big mess to me to figure out which list a VM is supposed to be in. It's even more experimental...

radj307 commented 6 months ago

This looks great so far! 👍

Dregu commented 6 months ago

This looks great so far! 👍

I think so too! I've been rocking the active notifications for a week with no issues, except for the few corner cases with empty notification I just fixed, so that feature is also merged here now.