search

radkovo / jStyleParser

jStyleParser is a CSS parser written in Java. It has its own application interface that is designed to allow an efficient CSS processing in Java and mapping the values to the Java data types. It parses CSS 2.1 style sheets into structures that can be efficiently assigned to DOM elements. It is intended be the primary CSS parser for the CSSBox library. While handling errors, it is user agent conforming according to the CSS specification.
http://cssbox.sourceforge.net/jstyleparser/
GNU Lesser General Public License v3.0
92 stars 49 forks source link

Test cases #6

Closed chetankothari closed 9 years ago

chetankothari commented 9 years ago

Test cases for the following issues issue #45 issue #49 issue #51 issue #52 [FAILS] issue #55 issue #56 [FAILS] issue #57

radkovo commented 9 years ago

Many thanks for the PR. I will merge it but I would like to fix the issues 52 and 56 first.

chetankothari commented 9 years ago

That will be great.

hrj commented 9 years ago

@radkovo We were thinking of chipping in with some bug fixes too. Looks like you are also attacking some issues. To avoid duplicate efforts, can you assign Chetan some issues? Since we are new to this project, simpler issues would be better for now. Thanks!

radkovo commented 9 years ago

That's a great idea! I believe I have fixed #56 now and I am planning to take a look at #52 now. Would you like to take a look at any of the bugs that remain open? The bugs marked 'accepted' should be fixed and prepared for the next release. There are not many at the moment but other bugs will appear for sure.

hrj commented 9 years ago

Thanks for the merge. We will start looking at open bugs and let you know if we can start working on any of them.

radkovo commented 9 years ago

Thanks for the PR. I merged it with subtle fixes on the #52 testcase. First, the test was relying on inherited green color for <p> but no inheritance was applied in getStyleById(). Second, match conditions only make sense with dynamic pseudo classes (e.g. :link); the structural ones (:first-child) are inferred from the code automatically.

chetankothari commented 9 years ago

Thanks for the Fixes.

hrj commented 9 years ago

@radkovo We looked at the existing open issues and couldn't find something to pick up. We are now going to run more of the w3c CSS tests and report any issues found. We will also try to pick up the easier ones.

Aside, are you planning a release in the near future?

radkovo commented 9 years ago

@hrj Great idea! I appreciate this very much. At the moment, most bugs seem to be resolved so it should be the right time for a release. It's planned for the next week if we don't come across some importan problem.