radlinskii / donkeytype

typing test TUI app
MIT License
17 stars 15 forks source link

Wpm calculation #44

Closed MercMayhem closed 1 year ago

MercMayhem commented 1 year ago

Closes #5

MercMayhem commented 1 year ago

@radlinskii can you review this?

radlinskii commented 1 year ago

Hey, Thank you for your contribution, I'm sorry @MercMayhem but I think I won't merge it, and close the issue. I've added the hacktoberfest-label already.

I started to think that this change is just not needed, and might be confusing.

If we were to add this change then we would need to update the colorising of words to display the whole word to some red color to show that the whole word is invalid and won't be counted.

Plus I think changes you made to computing the WPM, are obsolete, we should still count each word as 5 characters. So it would be more like how many characters were typed in the valid words, divided by 5, and that's how many valid "words" were typed.

MercMayhem commented 1 year ago

No problem @radlinskii :) . Loved working on donkeytype. Will definitely be following this project post Hacktoberfest.