search

radlinskii / donkeytype

typing test TUI app
MIT License
15 stars 16 forks source link

[feature] add help window feature when ? is pressed #70

Closed theghostmac closed 2 hours ago

radlinskii commented 1 week ago

Hi, great job at adding the help window!

I have one suggestion, I think it should only be accessible Normal mode, so either during Pause, or before running the test. Maybe also in the test results screen, but that can be a separate issue.

Guess the description wasn't clear enough, sorry about that.

theghostmac commented 1 week ago

Hey @radlinskii, I just addressed that in the last 2 commits.

Nice project btw.

theghostmac commented 1 week ago

Just did cargo fmt That should pass the build workflow.

radlinskii commented 5 days ago

the build job run is still failing, let me know if you plan to fix it yourself or not

radlinskii commented 5 days ago

ref #70

theghostmac commented 5 days ago

I'll fix it. I've seen the issue.

theghostmac commented 1 day ago

Hi @radlinskii I've addressed the issue. Was having a hectic week at work, hence the delay.

  1. Changed the render method to take impl FrameWrapperInterface instead of Frame
  2. Removed the generic since we're no longer using the raw Frame
  3. Changed direct frame methods to use the FrameWrapperInterface methods
  4. Simplified the imports since we don't need Backend anymore
radlinskii commented 4 hours ago

did you even try to run the app with your changes?

There is a runtime error when running the app on your branch, that is kind of hard to miss...

Before you've asked for approval even before the app would compile so I'm assuming you still didn't try to run it, which is kind of disturbing to me.

radlinskii commented 3 hours ago

when help window is rendered then 's' keypress should not start test, or if it did, than the help window should hide.

theghostmac commented 3 hours ago

Okay, the most user-friendly one is the econd option -- to automatically hide help when 's' is pressed.

The user can now:

  • Toggle help with "?"
  • Press 's' to dismiss help and start the test in one action
  • Still use 'q' to quit whether help is shown or not

Any other changes required to improve the user experience?