Closed theghostmac closed 2 hours ago
Hey @radlinskii, I just addressed that in the last 2 commits.
Nice project btw.
Just did cargo fmt
That should pass the build
workflow.
the build
job run is still failing, let me know if you plan to fix it yourself or not
ref #70
I'll fix it. I've seen the issue.
Hi @radlinskii I've addressed the issue. Was having a hectic week at work, hence the delay.
did you even try to run the app with your changes?
There is a runtime error when running the app on your branch, that is kind of hard to miss...
Before you've asked for approval even before the app would compile so I'm assuming you still didn't try to run it, which is kind of disturbing to me.
when help window is rendered then 's' keypress should not start test, or if it did, than the help window should hide.
Okay, the most user-friendly one is the econd option -- to automatically hide help when 's' is pressed.
The user can now:
Any other changes required to improve the user experience?
Hi, great job at adding the help window!
I have one suggestion, I think it should only be accessible Normal mode, so either during Pause, or before running the test. Maybe also in the test results screen, but that can be a separate issue.
Guess the description wasn't clear enough, sorry about that.