search

radlinskii / donkeytype

typing test TUI app
MIT License
17 stars 15 forks source link

support symbols #9

Closed radlinskii closed 1 year ago

radlinskii commented 1 year ago

Support symbols inside the expected input. Could be set as different levels (basic interpunction, programming), or even support user providing a list of symbols that could be used.

This feature should work similar to adding numbers inside the expected input. Please have a look inside the source code to see how it happens that if you pass numbers=true you can get numbers as part of your test's expected input.

User should be able to set it as an argument when running the program or put it inside her/his config file.

kritikash18 commented 1 year ago

Hey, can I work on this? Came back here 👋

radlinskii commented 1 year ago

Sure 👍

kritikash18 commented 1 year ago

Raised PR #40

phoffmeister commented 1 year ago

Also just created a PR for this #43 . This was an unfortunate timing. There was no update for a week so I looked into this. Then I saw the PR mentioned above. Still wanted to share what I did so far. Feel free to just discard my PR @radlinskii

radlinskii commented 1 year ago

after reviewing both PRs I merged #43 because:

Sorry @kritikash18 and thanks for your contribution, of course added hacktoberfest-accepted label to your PR too