search

radomirbosak / duden

CLI for http://duden.de dictionary written in Python
MIT License
100 stars 18 forks source link

Add pronunciation audio #183

Closed mundanevision20 closed 1 year ago

mundanevision20 commented 1 year ago

Hi @radomirbosak

As the title reads I'd like to add the option to display the urls for audio files provided by duden.de for the pronunciation of words.

Looking forward to your feedback.

Regards, Henning

radomirbosak commented 1 year ago

Thank you for this pull request @mundanevision20 ! I really appreciate it.

Please give me a few days to find time for review. Thank you!

mundanevision20 commented 1 year ago

Hi @radomirbosak

I tried to apply everything. Hope that I didn't miss anything. Sorry for deleting the _( it kept throwing issues in my linter and I didn't knew where they came from exactly.

Regards, Henning

radomirbosak commented 1 year ago

I pushed your changes to master branch. Thank you for contributing! :)

The only change I made was to rename the function from word_pronunciation_audio to pronunciation_audio_url, because the word context is obvious and adding _url makes it clear that it is the url link to the sound, and not the sound data itself.

And sorry it taking so long!