radon-h2020 / radon-gmt

🔀 RADON Graphical Modeling Tool based on Eclipse Winery
https://winery.readthedocs.io
Apache License 2.0
2 stars 5 forks source link

GMT - Node type definition: properly handle empty string as default values in properties #50

Closed kmlTE closed 3 years ago

kmlTE commented 3 years ago

Current behavior

When two consecutive properties are added with empty string ("") as a default value, only one property gets default empty string value in TOSCA. For example, adding "docker_user" and "docker_pass" properties with default value (""): Screenshot from 2021-03-25 15-29-16

Produces this TOSCA: Screenshot from 2021-03-25 15-33-41

Desired behavior

Both properties should have default empty string values

miwurster commented 3 years ago

This is currently not supported, unfortunately. The Winery parser/serializer strips off empty values atm.

I'll track it in our main repo for higher visibility.

miwurster commented 3 years ago

Hi @kmlTE, we fixed this in the upstream and it should be available within the latest Docker image (https://github.com/eclipse/winery/pull/573).

To enter an empty string value, users have to enter "" in the properties add/edit popup. This should result in the correct yaml syntax.

If you could verify at your end, I would then close the issue.

v-yussupov commented 3 years ago

Hi @kmlTE, please let us know if the issue is resolved for you, then we can close the issue. Thanks!

kmlTE commented 3 years ago

@v-yussupov @miwurster this issue is now resolved, thank you!