radon-h2020 / radon-particles

TOSCA definitions repository for the RADON project
Apache License 2.0
12 stars 30 forks source link

Updating the data pipeline node types #36

Closed pjakovits closed 4 years ago

pjakovits commented 4 years ago

Description

The goal of this pull request is to update and fix the data pipeline node types.

Have optimized the model hierarchy so that common properties, capabilities, requirements and interface implementations are inherited from "higher level" generic data pipeline types, so that creating new types through Winery is more rapid. Also fixed some issues with Ansible implementations that arose while testing.

Have also verified that the data pipeline node types and example service template designed through Winery (opentosca/radon-gmt:latest) is deplorable with xOpera (latest pip version) without manual modifications and errors.

Example Data pipeline service template:

Screenshot from 2020-06-05 14-06-30

Successfully deployed with xOpera after downloading and unpacking CSAR:

Screenshot from 2020-06-05 15-08-06

How it looks in NiFi, after it has been deployed in OpenStack:

Screenshot from 2020-06-05 14-29-05

pjakovits commented 4 years ago

Hey. Looks very good. However, it seems you deleted two policy types that are required the Decomposition Tool (added by @zhululai a couple of days ago).

Could you please revert these deletions?

Seems I made a mistake in solving merge issues with local modification (from admin touch) and remote rename of policy types.

I did an rebase with upstream (radon-h2020/radon-particles) and this issue should be solved now. Unfortunately there are still some unwanted changes due to a gmt admin touch. As I performed it when I started working on this fork, its difficult to revert all those changes, but I'll avoid that next time.

Also tested again with GMT and orchestrator that everything works.