search

radon-h2020 / radon-particles

TOSCA definitions repository for the RADON project
Apache License 2.0
12 stars 30 forks source link

Fix for issue when --user flag for pip was added inside a virtual environment #87

Closed duelle closed 3 years ago

duelle commented 3 years ago

The addition of the --user flag to the node type of the AWS Platform lead to issues when the deployment was executed within a Python virtual environment (virtualenv) as described in #86.

This change implements a switch, depending on whether there is an enabled virtual environment or not. If there is a virtual environment active, the --user flag is not added to the calls, while it is applied in all other cases.

@AlexSpart Could you please check that this does not break anything on your side (which was supposed to be fixed by the addition of the --user flag)?

miwurster commented 3 years ago

LGTM ... If @AlexSpart gives his "Go", I will merge it.

miwurster commented 3 years ago

@duelle could you please resolve the conflict?

duelle commented 3 years ago

@duelle could you please resolve the conflict?

Done @miwurster