Closed hustjieke closed 3 years ago
Merging #697 (fc10792) into master (af586a4) will decrease coverage by
0%
. The diff coverage isn/a
.
@@ Coverage Diff @@
## master #697 +/- ##
=====================================
- Coverage 89% 89% -1%
=====================================
Files 130 130
Lines 9279 9279
=====================================
- Hits 8269 8267 -2
- Misses 669 670 +1
- Partials 341 342 +1
Impacted Files | Coverage Δ | |
---|---|---|
src/backend/txn.go | 87% <0%> (-1%) |
:arrow_down: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update af586a4...c4de3c0. Read the comment docs.
Is there something wrong with the original code? If it is just to be consistent with the implementation of mysql, and the original implementation result is no problem, I think there is no need to modify it.
LGTM
[summary]
[test case] src/proxy/ddl_test.go src/vendor/github.com/xelabs/go-mysqlstack/sqlparser/ddl_test.go
[patch codecov] src/vendor/github.com/xelabs/go-mysqlstack/sqlparser/ast.go 96.2% src/vendor/github.com/xelabs/go-mysqlstack/sqlparser/ast_funcs.go 95.4% src/vendor/github.com/xelabs/go-mysqlstack/sqlparser/sql.go 69.6%